sigstore: reject legacy x509CertificateChain bundle format (SPEC §5.2)#105
Open
lsd-cat wants to merge 1 commit into
Open
sigstore: reject legacy x509CertificateChain bundle format (SPEC §5.2)#105lsd-cat wants to merge 1 commit into
lsd-cat wants to merge 1 commit into
Conversation
sigstore-python parses the legacy v0.1/v0.2 bundle layout (signing cert under verificationMaterial.x509CertificateChain). Per SPEC §5.2 the legacy layout MUST be rejected: it can carry intermediate/root CA certs (a misuse vector the v0.3 single-certificate form avoids), and tinfoil only produces v0.3 bundles. reject_legacy_bundle_format rejects a bundle whose verificationMaterial uses x509CertificateChain; called ahead of Bundle.from_json in the production verifier. Matches tinfoil-go/-rs/-js. Stacked on fix/sigstore-duplicate-sct-log. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sigstore-python parses the legacy v0.1/v0.2 bundle layout (signing cert under verificationMaterial.x509CertificateChain). Per SPEC §5.2 the legacy layout MUST be rejected: tinfoil only produces v0.3 bundles.
Summary by cubic
Enforces SPEC §5.2 by rejecting legacy v0.1/v0.2 Sigstore bundles that use
verificationMaterial.x509CertificateChain. Only v0.3 single-certificate bundles are accepted, closing a misuse vector and aligning with tinfoil-go/-rs/-js.Written for commit dcd178a. Summary will update on new commits.